Skip to content

Fix failing python tests on Windows - #3076

Merged
zcbenz merged 1 commit into
ml-explore:mainfrom
zcbenz:win-last-tests
Jan 30, 2026
Merged

Fix failing python tests on Windows#3076
zcbenz merged 1 commit into
ml-explore:mainfrom
zcbenz:win-last-tests

Conversation

@zcbenz

@zcbenz zcbenz commented Jan 28, 2026

Copy link
Copy Markdown
Member

Some small fixes making all tests pass on Windows:

  • Initialize ArrayDesc::data_size otherwise empty arrays which usually do not call array::set_data would get garbage data.
  • Only use tensor ops in grouped mm when tf32 is enabled.
  • Avoid accessing outputs[1] in SDPA when output_logsumexp is false.
  • Do not try to get vjp for mask in test_sdpa_grad.

awni
awni reviewed Jan 29, 2026
View reviewed changes
Comment thread mlx/backend/cuda/scaled_dot_product_attention.cpp Outdated
awni
awni approved these changes Jan 29, 2026
View reviewed changes

@awni awni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@zcbenz
zcbenz merged commit 8ef5395 into ml-explore:main Jan 30, 2026
16 checks passed
@zcbenz
zcbenz deleted the win-last-tests branch January 30, 2026 08:50
jzdziarski pushed a commit to jzdziarski/mlx that referenced this pull request Jul 26, 2026
@zcbenz
Fix failing python tests on Windows (ml-explore#3076)
32d3a58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awni awni awni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zcbenz @awni